Skip to content

Effect size in documentation should report cond-ctrl #366

@leetaiyi

Description

@leetaiyi

In your documentation (chapter 1.13), you have:

  -a ${norm_pileup_1}.gz \
  -a ${norm_pileup_2}.gz \
  -b ${tumor_pileup_1}.gz \
  -b ${tumor_pileup_2}.gz \

and I've checked in another issue that you clarified that the effect size is something like prop_a-prop_b, but we generally like using the control as the baseline, so I suggest changing the documentation to the following or calculate it as prop_b-prop_a instead.

  -a ${tumor_pileup_1}.gz \
  -a ${tumor_pileup_2}.gz \
  -b ${norm_pileup_1}.gz \
  -b ${norm_pileup_2}.gz \

I only found this out as I was comparing another method and found that we had inverse correlations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions