file_open: Do not return -EROFS when opening non-regular files#2164
Open
francescolavra wants to merge 2 commits into
Open
file_open: Do not return -EROFS when opening non-regular files#2164francescolavra wants to merge 2 commits into
francescolavra wants to merge 2 commits into
Conversation
added 2 commits
May 24, 2026 19:58
The is_dir() call is somewhat expensive, as is does a table lookup, and file_open() contains a couple of these function calls; then, there is a file_type_from_tuple() call which can potentially re-do the same lookups again. To avoid multiple table lookups, move the file_type_from_tuple() call at the top of the function, so that the `type` variable can be compared against known values in the rest of the function. No functional changes.
open() with O_WRONLY or O_RDWR on device files like /dev/null returns EROFS when the `readonly_rootfs` manifest option is enabled. Writes to non-regular files do not modify the filesystem, so these files should be exempt from the read-only check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open() with O_WRONLY or O_RDWR on device files like /dev/null returns EROFS when the
readonly_rootfsmanifest option is enabled. Writes to non-regular files do not modify the filesystem, so these files should be exempt from the read-only check.Closes #2134