fix(deploy): align kubernetes manifests with chart names - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly explain what this change does and why.
Scope
Ownership
CODEOWNERSMAINTAINERS.mdValidation
Check only the validation you actually ran.
Only check items you actually executed; do not check items you did not run.
make protocd controlplane && go test ./...cargo test --manifest-path dataplane/Cargo.toml --workspacebash -n scripts/render-release-manifest.shbash -n scripts/prepare-release-assets.shbash -n tests/e2e/run-kind.sh./tests/e2e/run-kind.sh./tests/conformance/run.shWhy This Validation Level
Explain why this validation level is enough.
Default to the cheapest validation path first, then move to more expensive layers only when needed. Do not default to running Kind.
Contract / API Changes
proto/If any of the items above are checked, explain compatibility impact and migration steps.
Release Communication
CHANGELOG.mddocs/user/compatibility-notes.mdIf you updated release communication, explain what upgrade or compatibility impact it covers.
Docs
Risks
Describe risks, rollback approach, and what reviewers should focus on.