Use JSON::MaybeXS instead of JSON.pm #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON::MaybeXS supports Cpanel::JSON::XS as well as JSON::XS and JSON::PP. Additionally, in the config phase of installation, it dynamically adjusts prereqs so that an ::XS implementation will be installed if XS is supported. Thus a custom warning in our Makefile.PL is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON::MaybeXS supports Cpanel::JSON::XS as well as JSON::XS and
JSON::PP.
Additionally, in the config phase of installation, it dynamically
adjusts prereqs so that an ::XS implementation will be installed if XS
is supported. Thus a custom warning in our Makefile.PL is no longer
needed.