Update Android implementation, remove Android gateway validation, refactor canMakePayments #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use implementation over deprecated compile - Update compile and target sdk to 28 - Add additional dependency for Google Pay
- Use non-deprecated classes - Remove not needed and not used FullWallet stuff - Receive allowed card networks from client - Receive allowed payment methods from client
- Remove it from PaymentRequest - Change input to require only required data
|
I'm pretty sure the GooglePay API update is a requirement as of the end of this month. How do we get someone to merge it in?! |
|
Hey there, thanks for doing this work. I'm helping out with this library. The PR has been open for a while and I'm not quite the expert on the Android side of things and Google Pay. What's the situation as of late 2020 with this? |
GFean
approved these changes
Apr 14, 2021
|
+1 for merge this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR changes a few things in the current Android implementation.
This also refactors canMakePayments. This is a breaking change, and changes how canMakePayments is exposed. Is no longer part of PaymentRequest, but it's directly exposed as a function. While having canMakePayments as part of PaymentRequest makes the API more compliant with the specification, there's no point in having to create a PaymentRequest just to verify that the device can make payments. For both Apple and Google Pay in fact, we only need to supply a small subset of the payment data (nothing at all in case of Apple Pay) to verify that the device supports the payment methods.