-
Notifications
You must be signed in to change notification settings - Fork 37
Add ability to view routes in a particular table #157
base: develop
Are you sure you want to change the base?
Conversation
|
pull request #157 |
|
Hi @pshemk - thanks for your contribution. We have thought about this improvement, see napalm-automation/napalm-base#174. |
napalm_junos/junos.py
Outdated
|
|
||
| def get_route_to(self, destination='', protocol=''): | ||
| """Return route details to a specific destination, learned from a certain protocol.""" | ||
| def get_route_to(self, destination='', protocol='', table=''): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename table to vrf
|
I've renamed table to 'vrf'. I realise that for consistency we should use vrf, but in junos a vrf can have multiple tables, so this might be a tad confusing too. What is 'next_hop_type' in this context? It looks like the current implementation pulls out all the route properties already: |
|
@pshemk this is pending clarification under napalm-automation/napalm-base#174. |
|
the commits have correct username now. |
issue #156