Skip to content

use plain dict in IOSDriver.get_bgp_neighbors_detail() #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktbyers merged 1 commit into from
Feb 9, 2025
Merged

use plain dict in IOSDriver.get_bgp_neighbors_detail() #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions napalm/ios/ios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import telnetlib
import tempfile
import uuid
from collections import defaultdict

from netmiko import FileTransfer, InLineTransfer

Expand Down Expand Up @@ -2076,7 +2075,7 @@ def get_bgp_neighbors(self):
return bgp_neighbor_data

def get_bgp_neighbors_detail(self, neighbor_address=""):
bgp_detail = defaultdict(lambda: defaultdict(lambda: []))
bgp_detail = {}

raw_bgp_sum = self._send_command("show ip bgp all sum").strip()

Expand Down Expand Up @@ -2227,6 +2226,14 @@ def get_bgp_neighbors_detail(self, neighbor_address=""):
"export_policy": bgp_neigh_afi["policy_out"],
}
)

vrf_name = details["routing_table"]
if vrf_name not in bgp_detail.keys():
bgp_detail[vrf_name] = {}
remote_as = details["remote_as"]
if remote_as not in bgp_detail[vrf_name].keys():
bgp_detail[vrf_name][remote_as] = []

bgp_detail[details["routing_table"]][details["remote_as"]].append(details)
return bgp_detail

Expand Down