Update pyproject.toml.jinja to drop python 3.8 and 3.9 #22
Conversation
willingc
changed the title
|
Just waiting for CI |
|
Ah, we'll need to merge #24, then merge it into this one. I've updated the description. |
|
😕 I don't understand why there's still py3.9 tests... |
|
There are still here: One needs to update workflows, not only tox. |
|
Ah, I missed that they ran in #24! 🤦 |
There was a problem hiding this comment.
Was about to come in and make an issue since the toml didn't appear up to date in my new plugin. As far as I can tell this fixes and clarifies everything I saw was wonky 👍
Wait, I think tox.ini also needs updated to drop 39 and add 313 (in addition to Grzegorz suggestions)
|
@willingc do you want to update this PR to remove the 3.9 mentions in the github workflows? I think that's all we need to get it green. |
|
Here's a PR to your fork @willingc that updates the workflows: |
willingc
force-pushed
the
patch-1
branch
3 times, most recently
from
0ef50db to
1df69f0
Compare
Co-authored-by: Grzegorz Bokota <[email protected]>
Co-authored-by: Juan Nunez-Iglesias <[email protected]>
Co-authored-by: Juan Nunez-Iglesias <[email protected]>
|
I'm going to troubleshoot this in a separate PR. |
Sounds good, just ping me when its ready or you need it looked at |
|
Replaced by #35 |
This PR replaces #22. It does the following: - add support for Python 3.13 - drop support for Python 3.8 and 3.9 - update templates to be consistent with these versions - add pre-commit config file to the repo. Includes argument to ruff format single quote style to match napari's pyproject.toml config - fix linting errors flagged by pre-commit - exclude jinja files from the repo's pre-commit check for end-of-file fixes since it requires changes to the end-of-file for template jinja files. When an extra newline is placed on the jinja files, it causes the generated-from-template files to fail testing.
Depends on #24