Bump min python version to 3.10, run precommit, fix everything #421
Conversation
updates: - https://github.com/psf/black → https://github.com/psf/black-pre-commit-mirror - [github.com/psf/black-pre-commit-mirror: 25.1.0 → 25.11.0](psf/black-pre-commit-mirror@25.1.0...25.11.0) - [github.com/astral-sh/ruff-pre-commit: v0.12.11 → v0.14.7](astral-sh/ruff-pre-commit@v0.12.11...v0.14.7) - [github.com/pre-commit/mirrors-mypy: v1.17.1 → v1.19.0](pre-commit/mirrors-mypy@v1.17.1...v1.19.0)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 37
Lines ? 2763
Branches ? 0
========================================
Hits ? 2763
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should be good to go. There were a few places where I had to do some manaul stuff or rewrite things. Most non-obvious stuff happened here: https://github.com/napari/npe2/pull/421/files/3923d9c7f1c8cda8440bf1c0cd83da6d22e655bc..f51c2b9e2bf1433f9439a35fee8cec3e83d4978f; commits before are basically ruff doing its thing plus me fixing the non autofixable issues. |
Czaki
left a comment
Czaki
left a comment
There was a problem hiding this comment.
Three small remarks. After being fixed, it could be merged.
Co-authored-by: Grzegorz Bokota <[email protected]>
|
I tested in napari installing some plugins, all is looking good. Let's merge this to unlock CI and make later PRs easier. |
2 participants
Lots of stuff needed fixing here... I expect many breakages to fix yet :P