Refactor CI scripts#47
Open
napetrov wants to merge 1 commit into
Open
Conversation
Reviewer's GuideThis PR refactors the CI folder structure by moving CircleCI utilities into .ci/scripts, updates all script path references accordingly, and removes the now-obsolete .circleci entry from CODEOWNERS. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @napetrov - I've reviewed your changes - here's some feedback:
- Verify that the updated relative paths (e.g.
python scripts/deselect_tests.py) resolve correctly in your CI working directory, since the scripts were moved from.circleciinto.ci/scripts. - Ensure the moved CI scripts in
.ci/scriptsstill have executable permissions set so they can run in the CI environment. - Consider adding or updating a CODEOWNERS entry for the new
.ci/scriptsdirectory if you need to maintain ownership on those files.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ci/scripts.circleciCODEOWNERS entryTesting
pip install pre-commit(fails: Could not find a version that satisfies the requirement pre-commit)https://chatgpt.com/codex/tasks/task_e_684727cae2a4832b8a2f86e530278723
Summary by Sourcery
Refactor CircleCI scripts by relocating utilities to a dedicated folder, updating script references, and removing obsolete CODEOWNERS entries
CI: