Skip to content

Refactor CI scripts#47

Open
napetrov wants to merge 1 commit into
mainfrom
codex/analyze-and-suggest-repo-structure-changes
Open

Refactor CI scripts#47
napetrov wants to merge 1 commit into
mainfrom
codex/analyze-and-suggest-repo-structure-changes

Conversation

@napetrov

@napetrov napetrov commented Jun 9, 2025

Copy link
Copy Markdown
Owner

Summary

  • move CircleCI utilities into .ci/scripts
  • update CI script paths
  • drop .circleci CODEOWNERS entry

Testing

  • pip install pre-commit (fails: Could not find a version that satisfies the requirement pre-commit)

https://chatgpt.com/codex/tasks/task_e_684727cae2a4832b8a2f86e530278723

Summary by Sourcery

Refactor CircleCI scripts by relocating utilities to a dedicated folder, updating script references, and removing obsolete CODEOWNERS entries

CI:

  • Relocate CircleCI utilities into the .ci/scripts directory and update all script paths accordingly
  • Remove the .circleci directory from the CODEOWNERS file

@sourcery-ai

sourcery-ai Bot commented Jun 9, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR refactors the CI folder structure by moving CircleCI utilities into .ci/scripts, updates all script path references accordingly, and removes the now-obsolete .circleci entry from CODEOWNERS.

File-Level Changes

Change Details Files
Update CI script paths to match relocated utilities
  • Adjust DESELECTED_TESTS export to point to scripts/deselect_tests.py instead of ../.circleci
  • Replace hardcoded path in run_sklearn_tests.sh
.ci/scripts/run_sklearn_tests.sh
Clean up CODEOWNERS to remove obsolete directory
  • Drop the .circleci entry from CODEOWNERS
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @napetrov - I've reviewed your changes - here's some feedback:

  • Verify that the updated relative paths (e.g. python scripts/deselect_tests.py) resolve correctly in your CI working directory, since the scripts were moved from .circleci into .ci/scripts.
  • Ensure the moved CI scripts in .ci/scripts still have executable permissions set so they can run in the CI environment.
  • Consider adding or updating a CODEOWNERS entry for the new .ci/scripts directory if you need to maintain ownership on those files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant