Skip to content

Fix delete on void pointer#49

Open
napetrov wants to merge 2 commits into
mainfrom
codex/fix-coverity-hit-for-deleting-void-pointer
Open

Fix delete on void pointer#49
napetrov wants to merge 2 commits into
mainfrom
codex/fix-coverity-hit-for-deleting-void-pointer

Conversation

@napetrov

@napetrov napetrov commented Jun 11, 2025

Copy link
Copy Markdown
Owner

Summary

  • fix undefined behavior by using operator delete[] when freeing raw pointers

Testing

  • pytest -k "" -q (fails: ModuleNotFoundError: No module named 'numpy')

https://chatgpt.com/codex/tasks/task_e_684910a8335c832b9c1afc8cbf882827

Summary by Sourcery

Bug Fixes:

  • Use ::operator delete[] instead of delete[] to free void pointers and avoid undefined behavior.

@sourcery-ai

sourcery-ai Bot commented Jun 11, 2025

Copy link
Copy Markdown

Reviewer's Guide

Use the global array deallocation function (::operator delete[]) instead of the class-specific delete[] to avoid undefined behavior when freeing void pointers in rawp_free_cap.

Sequence Diagram for Memory Deallocation in rawp_free_cap

sequenceDiagram
    participant PRT as "Python Runtime (Capsule)"
    participant RFC as "rawp_free_cap()"
    participant GMM as "Global Memory Manager"

    PRT->>RFC: Invoke with PyObject* cap
    RFC->>RFC: void* rp = PyCapsule_GetPointer(cap, NULL)
    alt Pointer 'rp' is valid (not NULL)
        RFC->>GMM: ::operator delete[](rp)
        RFC->>RFC: rp = NULL
    end
Loading

File-Level Changes

Change Details Files
Replace the raw-pointer deletion call to use the proper array deallocation operator.
  • Removed the old delete[] rp call
  • Added ::operator delete invocation
  • Left the subsequent rp null assignment unchanged
src/daal4py.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @napetrov - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant