Skip to content

fix(index): prevent stack overflow via async pendingRebuild #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinmarsian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(index): prevent stack overflow via async pendingRebuild #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/wired3/Controllers/IndexController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,13 @@ public class IndexController: TableController {
// If cancelled, forceReindex() has already queued a fresh rebuild via
// indexQueue.async; letting pendingRebuild fire here too would cause a
// redundant extra traversal immediately after the forced one.
//
// IMPORTANT: use indexQueue.async, not a direct recursive call.
// A synchronous call here overflows the stack when finalisation keeps
// failing (pendingRebuild stays true → 400+ frames → SIGBUS).
if !wasCancelled && pendingRebuild {
pendingRebuild = false
performFullRebuild()
indexQueue.async { [weak self] in self?.performFullRebuild() }
}
}

Expand Down
Loading