Skip to content

Modern Polars end-to-end tests #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tylerriccio33
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • [ x] βœ… Test
  • 🐳 Other

Related issues

Checklist

  • [x ] Code follows style guide (ruff)
  • [x ] Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Hi! I can add add the Modern Polars tests raised in issue #1945 . I created a draft of a single example to make sure this is in line with what you're looking for. In this particular example, modin and pure pyarrow aren't implemented. According to the issue, you'd like me to raise these as new issues so they can be implemented right?

Once this is clarified I can go through and add the rest of the examples, there aren't that many.

@MarcoGorelli
Copy link
Member

great start! this is exactly what I was hoping to see, thanks for having got the ball rolling!

@tylerriccio33
Copy link
Contributor Author

Nice, I'll get this show on the road

@MarcoGorelli
Copy link
Member

hi @tylerriccio33 is this still active? IMO we can merge these tests incrementally, we don't need to do it all in one go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants