Skip to content

fix: Never import from typing_extensions at runtime #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Never import from typing_extensions at runtime #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions narwhals/_translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,6 @@
from typing import Mapping
from typing import Protocol

_MIN_TYPING_EXTENSIONS = 4, 4, 0
_TYPING_EXTENSIONS = "typing_extensions"


def _typing_extensions_has_pep_696() -> bool: # pragma: no cover
from importlib.metadata import version
from importlib.util import find_spec

from narwhals.utils import parse_version

if find_spec(_TYPING_EXTENSIONS):
return parse_version(version(_TYPING_EXTENSIONS)) >= _MIN_TYPING_EXTENSIONS
return False


if TYPE_CHECKING:
import pyarrow as pa
from typing_extensions import Self
Expand All @@ -34,8 +19,6 @@ def _typing_extensions_has_pep_696() -> bool: # pragma: no cover

if sys.version_info >= (3, 13):
from typing import TypeVar
elif _typing_extensions_has_pep_696():
from typing_extensions import TypeVar
else:
from typing import TypeVar as _TypeVar

Expand Down
2 changes: 2 additions & 0 deletions tests/no_imports_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def test_polars(monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.delitem(sys.modules, "pandas")
monkeypatch.delitem(sys.modules, "numpy")
monkeypatch.delitem(sys.modules, "pyarrow", raising=False)
monkeypatch.delitem(sys.modules, "typing_extensions", raising=False)
monkeypatch.delitem(sys.modules, "duckdb", raising=False)
monkeypatch.delitem(sys.modules, "dask", raising=False)
monkeypatch.delitem(sys.modules, "ibis", raising=False)
Expand All @@ -31,6 +32,7 @@ def test_polars(monkeypatch: pytest.MonkeyPatch) -> None:
assert "ibis" not in sys.modules
assert "pyspark" not in sys.modules
assert "duckdb" not in sys.modules
assert "typing_extensions" not in sys.modules


def test_pandas(monkeypatch: pytest.MonkeyPatch) -> None:
Expand Down
Loading