Skip to content

enh: deprecate nw.new_series in favour of Series.from_iterable #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MarcoGorelli
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@dangotbanned
Copy link
Member

I thought that plan was from_iterable and/or from_numpy?

At the very least, could we change the spelling to match where the term originated?

@MarcoGorelli
Copy link
Member Author

yeah just struggling to think of a good name

if from_iterable doesn't come with any unexpected implications (which I can't think of), that's probably fine

@MarcoGorelli MarcoGorelli changed the title enh: deprecate nw.new_series in favour of Series.from_arraylike enh: deprecate nw.new_series in favour of Series.from_iterable Jun 5, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review June 5, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants