feat(expr-ir): Add DataFrame.write_{csv,parquet}
#3369
Merged
+153
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangotbanned
commented
Dec 23, 2025
Comment on lines
+21
to
+25
| IOTargetKind: TypeAlias = Literal["str", "Path", "PathLike"] | ||
| """Duplicated from `tests.read_scan_test.py`. | ||
|
|
||
| Needs extending for `BytesIO`. | ||
| """ |
Member
Author
There was a problem hiding this comment.
If anyone happens to read this:
the tests on main do not cover anything besides str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Third in the series is for
DslPlan::Sink.Well, only a very narrow subset of it actually.
Warning, still a lot
All of that is being condensed into:
narwhals/narwhals/_plan/logical_plan/plan.py
Lines 188 to 190 in 63dbc65
Related issues
ExprIR #2572BaseFrame.unpivot#3368