Adding Flare Advocate schema and testing it with an example#329
Adding Flare Advocate schema and testing it with an example#329ChiaraBartolini96 wants to merge 24 commits into
Conversation
New example schema. We removed the entries that are not important for our GCN.
New version of the schema with all the suggestions we received implemented. We deleted the entries that are not important for the GCN, too.
We have gcn/notices/fermi/lat/flare/flare.example.json that is the new version
We have gcn/notices/fermi/lat/flare/flare.schema.json that is the new version
|
We're working on some rearrangement of the spectral information. See #351. Once that is merged in, we'll suggest some changes on the LAT schema to utilize it. |
|
@ChiaraBartolini96 photon_flux would be: Kindly update your schema accordingly. |
I have updated the reference "../../core/spectral/GammaRay.schema.json" to "../../core/Spectral.schema.json" as suggested
We changed the flux, flux_error, and flux_unit accordingly with the new schema
Corrections suggested implemented: description is now updated, the schema folder name is updated, and the $ref entries are one level more nested.
| "ra": 215.62657, | ||
| "dec": 32.38623, |
There was a problem hiding this comment.
I know most of these flares are on known sources, but if there is a new source will you ever use ra_dec_error? If so, please add another example for an new or unknown flaring source.
There was a problem hiding this comment.
New sources are not selected by us because they need further checks and analysis. So, they can be part of GCN when we are 100% they are new sources, and we know what kind of sources they are.
Co-authored-by: Vidushi Sharma <103223246+Vidushi-GitHub@users.noreply.github.com>
Substituting index and index_error with alpha and alpha_error from PowerLaw.schema.json
Added core/models/PowerLaw.schema.json to use alpha and alpha_error inside it
Vidushi-GitHub
left a comment
Vidushi-GitHub
left a comment
There was a problem hiding this comment.
Looks good to me.
Except one validation test is failing.
Please run npx prettier -c ., it will fix the format.
Applied npx prettier -w . command to fix the format.
Applied npx prettier -w - to fix the format
Deletedthe flare directory which is not useful for our case
Schema in the correct location.
Example in the correct location.
|
This looks good, but there's a validation error. @Vidushi-GitHub will suggest the correction. |
| "unevaluatedProperties": false, | ||
| "allOf": [ | ||
| { | ||
| "$ref": "../../../core/Alert.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/Alert.schema.json" | |
| "$ref": "../../core/Alert.schema.json" |
| "$ref": "../../../core/Alert.schema.json" | ||
| }, | ||
| { | ||
| "$ref": "../../../core/DateTime.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/DateTime.schema.json" | |
| "$ref": "../../core/DateTime.schema.json" |
| "$ref": "../../../core/DateTime.schema.json" | ||
| }, | ||
| { | ||
| "$ref": "../../../core/Event.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/Event.schema.json" | |
| "$ref": "../../core/Event.schema.json" |
| "$ref": "../../../core/Event.schema.json" | ||
| }, | ||
| { | ||
| "$ref": "../../../core/Localization.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/Localization.schema.json" | |
| "$ref": "../../core/Localization.schema.json" |
| "$ref": "../../../core/Localization.schema.json" | ||
| }, | ||
| { | ||
| "$ref": "../../../core/Reporter.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/Reporter.schema.json" | |
| "$ref": "../../core/Reporter.schema.json" |
| "$ref": "../../../core/Reporter.schema.json" | ||
| }, | ||
| { | ||
| "$ref": "../../../core/Spectral.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/Spectral.schema.json" | |
| "$ref": "../../core/Spectral.schema.json" |
| "$ref": "../../../core/Spectral.schema.json" | ||
| }, | ||
| { | ||
| "$ref": "../../../core/models/PowerLaw.schema.json" |
There was a problem hiding this comment.
| "$ref": "../../../core/models/PowerLaw.schema.json" | |
| "$ref": "../../core/models/PowerLaw.schema.json" |
Vidushi-GitHub
left a comment
Vidushi-GitHub
left a comment
There was a problem hiding this comment.
The core schema directory structure needs to be fixed.
I have a question: do you plan to add more notices from the Flare group?
If so, it may be better to make flare a directory and keep alert.json.schema as a file within it. Currently, the location is fermi/lat, where flare.json.schema is a file.
In future, grb group will also add schema/directory in lat folder.
4 participants
I have added the first schema realized to create GCN notices for flaring sources detected within the flare advocate pipeline.
This is a simple and starting schema to verify if the format is correct and if there are any errors.