bpcp: reduce round trips for recursive tree copies - #87
Open
dcpagotto wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thank you for this PR. The efficiency improvement potential is high in your PR. In the course of our investigation, we discovered other flaws (not directly related to what your PR is addressing) so at this time we will focus on patching the problem first, and then return to your PR for further testing and analysis. In the meantime, we are adding your PR on our shorter list of to-do. Thanks! |
Contributor
|
let me know @iondev33 if you need help:
|
dcpagotto
force-pushed
the
fix/ion-84-recursive-dirlist
branch
from
June 10, 2026 05:39
f414c1e to
dc771c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi all,
this updates the recursive remote copy path so bpcp can ask for a recursive dir listing in one request when the responder supports it. this should avoid the extra per-directory listing round trips on larger trees.
i kept the legacy behavior available with -x, and the client still falls back when talking to older responders. the responder also skips entries it cannot safely include instead of failing the whole listing.
main things changed:
local checks run: