Skip to content

Conversation

@stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Oct 9, 2025

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Moves JS dependencies from @explorer-1/html to @explorer-1/common to allow customized JS imports in applications that use Explorer-1 (rather than using the dist, fully compiled, js).

Instructions to test

  1. pnpm install
  2. make html-storybook
  3. Make sure JS isn't broken in the internal header component (the NavBgOverlay error can be ignored)

@stephiescastle stephiescastle merged commit 165092c into main Oct 9, 2025
7 of 8 checks passed
@stephiescastle stephiescastle deleted the feature/moving-js-to-common branch October 9, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants