sparse map: report memory usage#721
Open
trey0 wants to merge 7 commits into
Open
Conversation
bcoltin
approved these changes
Apr 10, 2023
Contributor
|
last checked this PR on 7/19/2023 and #702 hasn't been tested in space yet, so waiting to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to report approximate memory usage of the sparse map data structures. This is not the same as the sparse map file size on disk because the in-memory representation is different from the file serialization, and memory usage also varies depending on the architecture we're running on.
This PR relies on bag of words memory usage reporting methods in #702. It's not expected to pass tests until #702 is merged to
masterand deployed toastrobee_base.The larger aim is to figure out the main contributors to sparse map memory usage so we can evaluate possible optimizations.
Here is example output for the
hamiltonmap running onx86_64, will be different onarmhf:This was originally opened as #703, but the GitHub PR diffs got stale somehow, so here it is as a new PR.