Skip to content

fixed polynomial fit derivative error - #105

Merged
markleader merged 1 commit into
nasa:mainfrom
markleader:fix/derivatives
Aug 17, 2026
Merged

fixed polynomial fit derivative error#105
markleader merged 1 commit into
nasa:mainfrom
markleader:fix/derivatives

Conversation

@markleader

Copy link
Copy Markdown
Contributor

Summary

Correct analytic equilibrium derivatives that caused large relative errors in species sensitivities.

Changes

  • Fix the NASA polynomial enthalpy derivative’s (a_1/T^2) coefficient.
  • Correct reduced equilibrium Jacobian and explicit-input terms.
  • Add regression tests for thermodynamic derivative identities.

Testing

Full fd_convergence.py sweep: worst large-species error (2.72\times10^{-5}).
pytest source/bind/python/tests: 68 passed.
ctest --test-dir build-dev: 15 passed.

Compatibility / Numerical behavior

  • No expected changes to numerical results
  • Expected changes: analytic derivative results are corrected; forward equilibrium solutions are unchanged.

@markleader
markleader merged commit 6b50fda into nasa:main Aug 17, 2026
23 checks passed
@markleader
markleader deleted the fix/derivatives branch August 17, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant