Vectorize equilibrium derivatives and reuse Jacobian factorization - #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reformulate equilibrium derivative post-processing as a vector-valued response Jacobian and reduce direct-method solve cost by reusing one Jacobian factorization for all sensitivity right-hand sides.
Changes
[state1, state2, w0]to the residual inputs.Testing
ctest --test-dir build-dev -R cea_core_test --output-on-failure(118 tests passed)Compatibility / Numerical behavior
The public derivative interface and scientific behavior are preserved; only the internal formulation and solve strategy have changed.