Skip to content

GQL-144: Add non-operational keys to graphql and Fix snyk vulnerabilities#184

Merged
eudoroolivares2016 merged 2 commits intomainfrom
GQL-144
Apr 15, 2026
Merged

GQL-144: Add non-operational keys to graphql and Fix snyk vulnerabilities#184
eudoroolivares2016 merged 2 commits intomainfrom
GQL-144

Conversation

@eudoroolivares2016
Copy link
Copy Markdown
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Apr 14, 2026

Overview

What is the feature?

This adds Searching for collections by the CMR query parameter include_non_operational (note documentation for that query parameter is only in SIT but, it exists in each env). Not specified in the ticket but, this search parameter at the individual collection level seems unnecessary.

Updating packages for security

What is the Solution?

New Collection query parameter

This fixes some dependency issues by simply doing an npm audit fix. cmr-ordering recently made the major release update for apollo-server. Based on the release notes and migration notes (https://www.apollographql.com/docs/apollo-server/migration) we shouldn't be adversely affected by this change

I also had to bump up the @as-integrations/aws-lambda package which we use to run apollo server in lambda
thankfully they updated their package for that explicit purpose see: https://github.com/apollo-server-integrations/apollo-server-integration-aws-lambda/releases/tag/v4.0.1

What areas of the application does this impact?

Collection Searching and generally the application due to the server upgrade

Testing

Reproduction steps

  • **Environment for testing:Any
  • **Collection to test with:NA
  1. Query using the parameter
query Collection($params: CollectionsInput) {
  collections(params: $params) {
    count
    items {
      conceptId
    }
  }
}

with

{
  "params": {
    "includeNonOperational": true
  }
} 

The count should be different as the returning values are

  1. Run snyk cli locally against this

  2. General regression test for the app since we are doing some major release upgrades

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@eudoroolivares2016 eudoroolivares2016 changed the title GQL-144: Add non-operational keys to graphql; bump apollo-server to l… GQL-144: Add non-operational keys to graphql and Fix snyk vulnerabilities Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (afb7fef) to head (0feb99b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         2719      2719           
  Branches       335       335           
=========================================
  Hits          2719      2719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eudoroolivares2016 eudoroolivares2016 merged commit 3a9bcec into main Apr 15, 2026
9 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the GQL-144 branch April 15, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants