Mark Generated C/C++ files as generated#658
Merged
Conversation
Collaborator
|
Thanks, this looks good! Question: Do you know what "vendored" is intended to be used for? It's a bit of an unusual term. I suppose we don't use "generated" for the C++ test output files because they are checked into the repo. |
Collaborator
Author
|
Here's the set of overrides that linguist allows: https://github.com/github-linguist/linguist/blob/main/docs/overrides.md#summary
There is "generated" but that means it won't show up in the diffs. That's usually used for code thats generated in someones tree that just does boilerplate. Since the generated files are part of the output, we definitely want the diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
I believe the remaining C++ files are our
.hppfor abstract type definitions. We can also mark the.fppfiles as any language other than Fortran if we wanted to (though the language must exist according to github-linguist unfortunately).Here's the set of languages understood by linguist https://github.com/github-linguist/linguist/blob/main/vendor/README.md.