Skip to content

Expand fpp-to-json tests #660

Merged
bocchino merged 17 commits intonasa:mainfrom
jwest115:fpp-468
Mar 20, 2025
Merged

Expand fpp-to-json tests #660
bocchino merged 17 commits intonasa:mainfrom
jwest115:fpp-468

Conversation

@jwest115
Copy link
Copy Markdown
Collaborator

@jwest115 jwest115 commented Mar 19, 2025

Run fpp-to-json on fpp-check test cases to improve code coverage.
Update trace file to prevent crashes when running the fpp-to-json native build.

Closes #468.

@jwest115 jwest115 requested a review from bocchino March 19, 2025 00:34
@jwest115 jwest115 changed the title Improve fpp-to-json tests Expand fpp-to-json tests Mar 19, 2025
Copy link
Copy Markdown
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I refactored the new fpp-to-json/fpp-check tests a bit. I moved those tests to a subdirectory. I used find instead of iterating over directories to find the fpp-check test input files. It's more efficient, and it finds files at all directory levels; before we were only going down one level. I revised the format of the test output so that the longer test names don't crash into the PASSED or FAILED output.

I also ran dostounix on the top-level source file for fpp-to-json. There were some stray ^M characters in there, probably from back when the file was created.

@bocchino bocchino merged commit a5b1ec2 into nasa:main Mar 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand fpp-to-json tests to run against fpp-check

2 participants