Conversation
This was referenced Apr 10, 2025
bocchino
reviewed
Apr 10, 2025
bocchino
reviewed
Apr 10, 2025
bocchino
reviewed
Apr 10, 2025
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Good catch! This PR looks good to me. Please look at the comments I made.
Collaborator
|
Looks good! I'm just running check-cpp now. |
bocchino
reviewed
Apr 10, 2025
bocchino
approved these changes
Apr 10, 2025
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
Looks good! check-cpp passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#645 did not get the string alias codegen quite right. We need to keep the same underlying C++ type in all locations that utilize FPP strings (and their aliases).
This PR will only utilize the aliased name if the codegen expects. We decided that the original (pre-alias) behavior should be maintained for string aliases. A C++Fw::Stringusing AliasName = Fw::Stringis still generatedThere was a missing testcase that caused issues while working on #659 (see updated
.fpptest).