UT: Do not add -g flag if CMAKE_BUILD_TYPE is set to "Release"#3562
Closed
pcrosemurgy wants to merge 1 commit intonasa:develfrom
Closed
UT: Do not add -g flag if CMAKE_BUILD_TYPE is set to "Release"#3562pcrosemurgy wants to merge 1 commit intonasa:develfrom
-g flag if CMAKE_BUILD_TYPE is set to "Release"#3562pcrosemurgy wants to merge 1 commit intonasa:develfrom
Conversation
LeStarch
approved these changes
May 6, 2025
Collaborator
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
This looks right, although I wonder if the -g is needed at all. CMake Debug should add that for us.
Contributor
Author
|
Closed, nasa/fpp#689 will fix our underlying issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
By default when CMake testing is enabled
CMAKE_BUILD_TYPEis set to "Debug". This PR will not break any backwards compatibility.If, in a deployment's top-level CMakeLists.txt,
CMAKE_BUILD_TYPEis explicitly set to "Release" this should be respected and the debug flag should be omittedRationale
This is needed in order to work around compile times for AC files with very long
toString()impls (for example, AC array data types with thousands of args). When-gis used, the UT builds fail to complete (that is, fail to complete within any human/reasonable time).