Skip to content

Clean up DpCatalog test artifacts in destructor#4714

Open
heathdutton wants to merge 1 commit intonasa:develfrom
heathdutton:fix/4360-dpcatalog-test-cleanup
Open

Clean up DpCatalog test artifacts in destructor#4714
heathdutton wants to merge 1 commit intonasa:develfrom
heathdutton:fix/4360-dpcatalog-test-cleanup

Conversation

@heathdutton
Copy link
Contributor

Related Issue(s) #4360
Has Unit Tests (y/n) Y (existing tests pass)
Documentation Included (y/n) N
Generative AI was used in this contribution (y/n) Y

Change Description

Adds std::system("rm -rf ./DpTest*") to the DpCatalogTester destructor, mirroring the identical cleanup already present in the constructor.

Rationale

When a test assertion fails, the cleanup at the end of readDps() never runs, leaving residual DpTest* directories on disk. The constructor cleans up before the next run, but only if you run the tests again. Adding cleanup to the destructor ensures artifacts are removed on every exit since C++ guarantees destructor execution during stack unwinding.

Testing/Review Recommendations

All 19 existing DpCatalog unit tests pass. Verified no DpTest* artifacts remain on disk after the test run completes.

Future Work

None.

AI Usage (see policy)

Claude Code was used for codebase exploration, identifying the root cause, and drafting the one-line fix. The change was reviewed and tested manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant