Clean up DpCatalog test artifacts in destructor#4714
Open
heathdutton wants to merge 1 commit intonasa:develfrom
Open
Clean up DpCatalog test artifacts in destructor#4714heathdutton wants to merge 1 commit intonasa:develfrom
heathdutton wants to merge 1 commit intonasa:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Adds
std::system("rm -rf ./DpTest*")to theDpCatalogTesterdestructor, mirroring the identical cleanup already present in the constructor.Rationale
When a test assertion fails, the cleanup at the end of
readDps()never runs, leaving residualDpTest*directories on disk. The constructor cleans up before the next run, but only if you run the tests again. Adding cleanup to the destructor ensures artifacts are removed on every exit since C++ guarantees destructor execution during stack unwinding.Testing/Review Recommendations
All 19 existing DpCatalog unit tests pass. Verified no
DpTest*artifacts remain on disk after the test run completes.Future Work
None.
AI Usage (see policy)
Claude Code was used for codebase exploration, identifying the root cause, and drafting the one-line fix. The change was reviewed and tested manually.