Skip to content

Change configure method parameters to const#4961

Merged
thomas-bc merged 5 commits intodevelfrom
LeStarch-patch-2
Apr 9, 2026
Merged

Change configure method parameters to const#4961
thomas-bc merged 5 commits intodevelfrom
LeStarch-patch-2

Conversation

@LeStarch
Copy link
Copy Markdown
Collaborator

@LeStarch LeStarch commented Apr 6, 2026

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)
Generative AI was used in this contribution (y/n)

Change Description

Because const

m_cycleSlips(0) {}

void ActiveRateGroup::configure(U32 contexts[], FwIndexType numContexts) {
void ActiveRateGroup::configure(const U32 contexts[], const FwIndexType numContexts) {
PassiveRateGroup::~PassiveRateGroup() {}

void PassiveRateGroup::configure(U32 contexts[], FwIndexType numContexts) {
void PassiveRateGroup::configure(const U32 contexts[], const FwIndexType numContexts) {
m_cycleSlips(0) {}

void ActiveRateGroup::configure(U32 contexts[], FwIndexType numContexts) {
void ActiveRateGroup::configure(const U32 contexts[], const FwIndexType numContexts) {
PassiveRateGroup::~PassiveRateGroup() {}

void PassiveRateGroup::configure(U32 contexts[], FwIndexType numContexts) {
void PassiveRateGroup::configure(const U32 contexts[], const FwIndexType numContexts) {
struct Divider {
//! Initializes divisor and offset to 0 (unused)
Divider() : divisor(0), offset(0) {}
constexpr Divider() : divisor(0), offset(0) {}
constexpr Divider() : divisor(0), offset(0) {}
//! Initializes divisor and offset to passed-in pair
Divider(FwSizeType divisorIn, FwSizeType offsetIn) : divisor(divisorIn), offset(offsetIn) {}
constexpr Divider(FwSizeType divisorIn, FwSizeType offsetIn) : divisor(divisorIn), offset(offsetIn) {}
Copy link
Copy Markdown
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thomas-bc thomas-bc merged commit 8487319 into devel Apr 9, 2026
40 checks passed
@thomas-bc thomas-bc deleted the LeStarch-patch-2 branch April 9, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants