Ref: call deinitComponents during topology teardown#4997
Closed
dcpagotto wants to merge 1 commit intonasa:develfrom
Closed
Ref: call deinitComponents during topology teardown#4997dcpagotto wants to merge 1 commit intonasa:develfrom
dcpagotto wants to merge 1 commit intonasa:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a small gap in the Ref teardown flow.
today teardown calls tearDownComponents(state), but it does not call deinitComponents(state). That leaves the shutdown path incomplete, since component owned teardown runs but final deinit never happens.
the fix is to call deinitComponents(state) right after tearDownComponents(state), and update the header comment so the documented lifecylce matches the actual one.
I validated this locally with generate, build, and execution on WSL, and I did not hit any regresison on that path.
if there is any reason this deinit step was intentionally skipped before, I would aprecaite a second look, but from what I can see this was just a missnig step in teardown.
Thanks! Dhiego Pagotto...