Backup/add rng directive fpy pre rebase#5002
Closed
Nickg02 wants to merge 5 commits intonasa:develfrom
Closed
Conversation
…h the sequencer. Passes added test.
| ASSERT_EQ(result, Signal::stmtResponse_failure); | ||
| ASSERT_EQ(err, DirectiveError::STACK_UNDERFLOW); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
add testers for the deserialize_xyz behavior. see how pushTime does it
| ASSERT_EQ(result, Signal::stmtResponse_success); | ||
| ASSERT_EQ(err, DirectiveError::NO_ERROR); | ||
| ASSERT_EQ(tester_pop<U32>(), expectedRng()); | ||
|
|
Collaborator
|
Blocked on CCB. |
Author
|
Closing this draft in favor of a cleaner branch/PR: #5062 The original branch accumulated rebase/conflict history, so I recreated the work on top of the latest upstream/devel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Rationale
Testing/Review Recommendations
Future Work
AI Usage (see policy)