Validate Fpy Sequence Arg Names and Types#5031
Draft
Lex-ari wants to merge 17 commits intonasa:develfrom
Draft
Conversation
525bb7b to
31282aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Adds comprehensive argument validation support to the FpySequencer component. The sequencer can reads argument specifications (arg_specs) from Fpy bytecode files and validates that provided runtime arguments match the expected sizes.
This changes the header / body format of Fpy sequences, to include argument specs inside the body. The body is deserialized and makes use of the argumentCount inside the header to validate the buffer size. Additionally, it saves the argument specs with an argument name, and type name, to allow for future development on matching arg names and types for calling arguments with sequences.
Rationale
Support for type-checking fpy sequences with arguments, as well as calling sequences with arguments from other sequences to match names and typenames.
Testing/Review Recommendations
Check unit test passage on new validation cases, including arguments added to fpy sequences.
Future Work
More robust UT's and testing, such as typename-checking.
Notes
Have #4962 Merge before this one
AI Usage (see policy)
Claude-chan helped
v2.1.92 sonnet used to autocomplete validation
All lines of code were human reviewed.