Add FppTestProject Direct Port Call Integration Tests to CI#5033
Merged
thomas-bc merged 1 commit intonasa:develfrom Apr 20, 2026
Merged
Add FppTestProject Direct Port Call Integration Tests to CI#5033thomas-bc merged 1 commit intonasa:develfrom
thomas-bc merged 1 commit intonasa:develfrom
Conversation
LeStarch
approved these changes
Apr 20, 2026
Collaborator
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
LGTM. Minor question: why JSON generation?
thomas-bc
approved these changes
Apr 20, 2026
Collaborator
Author
|
@LeStarch None other than the indirect ports has it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Adds a build job with direct port call execution for our FPP integration tests
Rationale
The standard FppTestProject uses BUILD_UT which disables direct port calls in the standard
FpConfig.h. This option overrides that default for the topology tests since we don't need indirect port calls for those and allows us to test direct port calls in a unit-testy way.AI Usage (see policy)
Claude did it. I ran it manually as well, seems fine.