PR-5034 - Fix ground file upload processing of different file size fo…#5035
Closed
bitWarrior wants to merge 2 commits intonasa:develfrom
Closed
PR-5034 - Fix ground file upload processing of different file size fo…#5035bitWarrior wants to merge 2 commits intonasa:develfrom
bitWarrior wants to merge 2 commits intonasa:develfrom
Conversation
Collaborator
|
Please make sure the issues addressed have gone through the CCB. We will hold off on this one until we have approval |
Collaborator
Author
|
Fixed formatting issue |
Collaborator
|
This PR does not fix this issue as recommended by the CCB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Added explicit OVERWRITE to trigger the logic in Os/Posix/File.cpp to overwrite the file when opening the file the ground is uploading:
WAS: return this->osFile.open(path, Os::File::OPEN_WRITE);
I S: return this->osFile.open(path, Os::File::OPEN_CREATE,
Os::File::OverwriteType::OVERWRITE);
Rationale
The overwrite ensures any older stale data in the older version of the file will be erased.
Testing/Review Recommendations
Re-run unit tests; Upload larger and then smaller versions of the same file.
Future Work
N/A
AI Usage (see policy)
N/A