Skip to content

PR-5034 - Fix ground file upload processing of different file size fo…#5035

Closed
bitWarrior wants to merge 2 commits intonasa:develfrom
bitWarrior:PR-5034
Closed

PR-5034 - Fix ground file upload processing of different file size fo…#5035
bitWarrior wants to merge 2 commits intonasa:develfrom
bitWarrior:PR-5034

Conversation

@bitWarrior
Copy link
Copy Markdown
Collaborator

5034
Has Unit Tests (N)
Documentation Included (N)
Generative AI was used in this contribution (N)

Change Description

Added explicit OVERWRITE to trigger the logic in Os/Posix/File.cpp to overwrite the file when opening the file the ground is uploading:

WAS: return this->osFile.open(path, Os::File::OPEN_WRITE);
I S: return this->osFile.open(path, Os::File::OPEN_CREATE,
Os::File::OverwriteType::OVERWRITE);

Rationale

The overwrite ensures any older stale data in the older version of the file will be erased.

Testing/Review Recommendations

Re-run unit tests; Upload larger and then smaller versions of the same file.

Future Work

N/A

AI Usage (see policy)

N/A

@LeStarch
Copy link
Copy Markdown
Collaborator

Please make sure the issues addressed have gone through the CCB. We will hold off on this one until we have approval

@LeStarch LeStarch moved this to CCB in F´ Development Apr 20, 2026
@thomas-bc thomas-bc added CCB PR needs to go through CCB process Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates. labels Apr 20, 2026
@bitWarrior
Copy link
Copy Markdown
Collaborator Author

Fixed formatting issue

@LeStarch
Copy link
Copy Markdown
Collaborator

This PR does not fix this issue as recommended by the CCB.

@LeStarch LeStarch closed this Apr 24, 2026
@github-project-automation github-project-automation Bot moved this from CCB to Done in F´ Development Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates. CCB PR needs to go through CCB process

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants