Skip to content

Fix FileWorker compatibility with 32-bit baremetal platforms#5046

Merged
LeStarch merged 4 commits intonasa:develfrom
celskeggs:patch-28
Apr 24, 2026
Merged

Fix FileWorker compatibility with 32-bit baremetal platforms#5046
LeStarch merged 4 commits intonasa:develfrom
celskeggs:patch-28

Conversation

@celskeggs
Copy link
Copy Markdown
Collaborator

Related Issue(s) n/a
Has Unit Tests (y/n) n
Documentation Included (y/n) n
Generative AI was used in this contribution (y/n) n

Change Description

Fix FileWorker compatibility with 32-bit baremetal platforms. In particular:

  • Types need to match between FileWorker.cpp and FileWorker.hpp. (Use FwSizeType everywhere, it is not equivalent to U64.)
  • FileTester depends on POSIX-only filesystem implementations and therefore must be restricted to POSIX-compatible platforms.

Rationale

When running fprime-util build in the top level directory on any platform, we expect the build to complete successfully.

Testing/Review Recommendations

n/a

Future Work

n/a

AI Usage (see policy)

Not used

Copy link
Copy Markdown
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We may want to exclude the FileWorkerTestError UT from non-POSIX builds as well, since it depends on FileTester

@celskeggs
Copy link
Copy Markdown
Collaborator Author

celskeggs commented Apr 21, 2026

Looks like this collides with #5021, so I'll need to pull this back and make some fixes

@thomas-bc
Copy link
Copy Markdown
Collaborator

@celskeggs we are trying to expedite a v4.2.2 hotfix for this — I figured you wouldn't mind if I took over your branch. Thanks!

@thomas-bc thomas-bc requested a review from LeStarch April 23, 2026 21:33
Comment thread Svc/FileWorker/CMakeLists.txt Outdated
@LeStarch LeStarch merged commit ebd2306 into nasa:devel Apr 24, 2026
54 checks passed
thomas-bc added a commit that referenced this pull request Apr 24, 2026
* Fix FileWorker compatibility with 32-bit baremetal platforms

* Improve non-Posix registration of FileTester

Co-authored-by: Copilot <copilot@github.com>

* use STATUS instead of INFO

---------

Co-authored-by: thomas-bc <thomas.boyerchammard@gmail.com>
Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants