Compile-time Override of Default Assert Hooks#5058
Open
Kronos3 wants to merge 3 commits intonasa:develfrom
Open
Compile-time Override of Default Assert Hooks#5058Kronos3 wants to merge 3 commits intonasa:develfrom
Kronos3 wants to merge 3 commits intonasa:develfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #define fileIdFs "Assert: \"%s:%" PRI_FwSizeType "\"" | ||
| #endif | ||
|
|
||
| void Fw::defaultPrintAssert(const CHAR* msg) { |
| (void)fputs("\n", stderr); | ||
| } | ||
|
|
||
| void Fw::defaultReportAssert(FILE_NAME_ARG file, |
| FwAssertArgType arg4, | ||
| FwAssertArgType arg5, | ||
| FwAssertArgType arg6, | ||
| CHAR* destBuffer, |
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
thomas-bc
added
Breaking Changes / Needs Release Notes
| #include <Fw/Types/format.hpp> | ||
| #include <cassert> | ||
| #include <cstdio> | ||
| #include <cstdlib> |
| assert(0); | ||
| abort(); | ||
| } | ||
|
|
| assert(0); | ||
| abort(); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Implements #5057 (assuming it passes CCB, close this otherwise...)
Rationale
See issue. TLDR, for small platform
Testing/Review Recommendations
Future Work
Need to update platforms to point to this default assert implementation.
AI Usage (see policy)
Claude code read the issue and drafted solution. I made some naming changes but in general looks pretty good.
Closes #5057