Update additional classes in Os to offer the alias option - #5955
bevinduckett wants to merge 10 commits into
Conversation
… Mutex, & ConditionVariable
This reverts commit 5f495b261c3c7cc69dd075db45c2df270ce371a3, reversing changes made to ae321743ed113ab34cc48a2abcd17b97581acf6c. Undoes the merge commit because fprime devel commit c103965 is breaking our build
… revert The Aug 19 "Revert Merge branch devel into multi-os-alias" undid a devel merge because fpp 3.3.0a17 broke the build. That issue was fixed upstream by 1fadfda (bump to stable fpp 3.3.0), and both commits are already in devel's history, but the revert's content was never re-integrated. This commit fixes that (modifies about 170 non-Os files).
Coverage report — base
|
| Module | Line | Δ | Function | Δ | Branch | Δ |
|---|---|---|---|---|---|---|
Os/Posix |
70.64 | -0.64 | 87.50 | +0.00 | 50.67 | -0.67 |
Modules changed
| Module | Line | Δ | Function | Δ | Branch | Δ |
|---|---|---|---|---|---|---|
Os/Posix |
70.64 | -0.64 | 87.50 | +0.00 | 50.67 | -0.67 |
Os |
19.91 | +0.14 | 22.75 | +0.30 | 17.35 | -0.06 |
Os/Generic/Types |
92.14 | +0.35 | 92.86 | +0.00 | 75.70 | +0.93 |
Fw/DataStructures |
97.69 | +0.36 | 97.14 | +0.00 | 82.30 | +0.73 |
New modules
| Module | Line | Function | Branch |
|---|---|---|---|
Fw/Prm |
0.00 | 0.00 | 0.00 |
Svc/Ccsds/AesGcmDecryptor |
96.72 | 100.00 | 82.46 |
Svc/Ccsds/AesGcmEncryptor |
95.00 | 100.00 | 82.09 |
Modules without UTs
CFDP/Checksum/GTest, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/Ports/DataTypes, Drv/PosixUartDriver, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Obj, Fw/Port, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Ccsds/Types, Svc/Ccsds/Utils, Svc/FatalHandler, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComCcsdsSdls, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/DpCompression, Svc/Subtopologies/FileHandling, Svc/Subtopologies/FileHandlingCfdp, Svc/Subtopologies/FileHandlingCfdp/FileHandlingCfdpConfig, TestDeploymentsProject/Ref/DpDemo, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, cmake/test/data/TestConfigDeployment, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestDuplicateDirective, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestLinkDepends, cmake/test/data/TestDeployment/TestRelative, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent
This branch has not been deployed
1 participant
Change Description
Other PRs related to adding OS aliases (#5249)
#5617 added the Os::RawTime alias
#5936 is for the Os::Mutex alias
This PR covers the remainder of the "simple" cases notes in #5249, specifically it adds aliases for:
Os::RawTime
Os::File
Os::FileSystem
Os::Directory
Os::ConditionVariable
Os::Console
Os::CountingSemaphore
Os::Cpu
Os::Memory
Rationale
See discussion in #5249
Testing/Review Recommendations
Verify the build works & verify UTs pass.
Future Work
Future work is to decide whether to convert the more complex classes, see
AI Usage (see policy)
AI was used to assist in refactoring / boilerplate comment & code generation and to assist with debugging build system / unit test errors. All UT changes have been reviewed