Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2180: Build process needs build package. #31

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

flamingbear
Copy link
Member

Description

This should fix the build pacakge.

Jira Issue ID

DAS-2180

Local Test Steps

None. Just hope.

commented out some code and ran act

[Publish Harmony Browse Image Generator (HyBIG)/build_and_publish]   ✅  Success - Main Install build package
[Publish Harmony Browse Image Generator (HyBIG)/build_and_publish] ⭐ Run Main Build hybig-py package
[Publish Harmony Browse Image Generator (HyBIG)/build_and_publish]   🐳  docker exec cmd=[bash --noprofile --norc -e -o pipefail /var/run/act/workflow/5] user= workdir=
| * Creating isolated environment: venv+pip...
| * Installing packages in isolated environment:
|   - hatch-requirements-txt
|   - hatchling
| * Getting build dependencies for sdist...
| * Building sdist...
| * Building wheel from sdist
| * Creating isolated environment: venv+pip...
| * Installing packages in isolated environment:
|   - hatch-requirements-txt
|   - hatchling
| * Getting build dependencies for wheel...
| * Building wheel...
| Successfully built hybig_py-2.0.0.tar.gz and hybig_py-2.0.0-py3-none-any.whl

PR Acceptance Checklist

  • [n/a] Jira ticket acceptance criteria met.
  • [n/a] CHANGELOG.md updated to include high level summary of PR changes.
  • [n/a] docker/service_version.txt updated if publishing a release.
  • [n/a] Tests added/updated and passing.
  • [n/a] Documentation updated (if needed).

@flamingbear
Copy link
Member Author

flamingbear commented Aug 1, 2024

I do wonder if this won't actually publish because the version is the same as main 🤔 Is there a way to force the publish to run?

@owenlittlejohns
Copy link
Member

Good question. I think you can manually trigger the publication workflow (the workflow_dispatch was added for the 1.0.0 release, I think).

You might need to delete the GitHub release, the git tag and the ghcr.io package. Now I've said all that, maybe just going to 2.0.1 is better?

@flamingbear
Copy link
Member Author

flamingbear commented Aug 1, 2024

Lucky for me, it didn't create a v2 release on github, there is no release or tag, just the docker image, which will get written over? IDC I can bump the version and we can just try again. probably the easiest.

Actually, I'd rather just trigger it by hand after the merge and see if that works.

@@ -83,6 +83,11 @@ jobs:
with:
python-version: '3.11'

- name: Install build package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Probably a dopey question): Does this need the GDAL wizardry that run_lib_tests.yml includes?

Copy link
Member Author

@flamingbear flamingbear Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to find out. I am not an expert at package building, but my few google searches said no and when I ran it with ACT it showed that it did build the package. Of course I didn't test that (the built package), but the package should only have information about what it needs to build not the actual libraries no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Let me approve this and then we can give it a whirl!

Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@@ -83,6 +83,11 @@ jobs:
with:
python-version: '3.11'

- name: Install build package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Let me approve this and then we can give it a whirl!

@flamingbear flamingbear merged commit 0e13371 into main Aug 1, 2024
6 checks passed
@flamingbear flamingbear deleted the mhs/DAS-2180/fix-build-and-publish branch August 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants