-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAS-2180: Build process needs build package. #31
Conversation
I do wonder if this won't actually publish because the version is the same as |
Good question. I think you can manually trigger the publication workflow (the You might need to delete the GitHub release, the git tag and the ghcr.io package. Now I've said all that, maybe just going to 2.0.1 is better? |
Lucky for me, it didn't create a v2 release on github, there is no release or tag, just the docker image, which will get written over? IDC I can bump the version and we can just try again. probably the easiest. Actually, I'd rather just trigger it by hand after the merge and see if that works. |
@@ -83,6 +83,11 @@ jobs: | |||
with: | |||
python-version: '3.11' | |||
|
|||
- name: Install build package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Probably a dopey question): Does this need the GDAL wizardry that run_lib_tests.yml
includes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to find out. I am not an expert at package building, but my few google searches said no and when I ran it with ACT it showed that it did build the package. Of course I didn't test that (the built package), but the package should only have information about what it needs to build not the actual libraries no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Let me approve this and then we can give it a whirl!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
@@ -83,6 +83,11 @@ jobs: | |||
with: | |||
python-version: '3.11' | |||
|
|||
- name: Install build package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Let me approve this and then we can give it a whirl!
Description
This should fix the build pacakge.
Jira Issue ID
DAS-2180
Local Test Steps
None. Just hope.
commented out some code and ran act
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.