TRT-635: Update to harmony-service-lib-py==2.8.0.#38
Conversation
|
The Snyk scans initially failed because bumping the dependencies made them no longer compatible with Python 3.9. But the service image is using Python 3.11, so I've added the |
There was a problem hiding this comment.
I didn't do anything to the other dependencies - primarily because this PR is really just meant to see if the CI/CD updates work, and bumping harmony-service-lib was on my list of obvious things to update soon.
| Message({"format": {"mime": "application/x-netcdf4"}}), "", None | ||
| Message({"format": {"mime": "application/x-netcdf4"}}), | ||
| config=self.config, | ||
| catalog=None, |
There was a problem hiding this comment.
A good next step would be to use a pystac.Catalog object here, as Harmony expects. But at least there is a proper Config object now.
flamingbear
left a comment
flamingbear
left a comment
There was a problem hiding this comment.
All of these changes make sense. tests passed and regressions against localhost also passed.
2 participants
Description
This PR updates the
harmony-serivce-lib-pydependency (andpystacto make sure that everything still works). There are minimal meaningful updates beyond import paths being changed and one place where there was a fallback for authorisation (back when EDL credentials were still an option within the service). That's no longer supported, though, and was already on the way to deprecation when this code was using it.I also removed the extraneous
fetch-tagsargument from the CI/CD, following the demonstration from @flamingbear that it was unnecessary withfetch-depth: 0.Jira Issue ID
N/A
Local Test Steps
./bin/build-image && ./bin/build-test && ./bin/run-test. All tests should pass.LOCALLY_DEPLOYED_SERVICES=harmony-gdal-adapter)harmony_host_url='http://localhost:3000'. All tests should still pass.PR Acceptance Checklist
Jira ticket acceptance criteria met.version.txtandCHANGELOG.mdupdated if any service code is changed.Documentation updated (if needed).