TRT-635: Refine HarmonyAdapter.reformat method.#39
Merged
owenlittlejohns merged 1 commit intomainfrom Sep 24, 2025
Merged
Conversation
flamingbear
approved these changes
Sep 24, 2025
Member
flamingbear
left a comment
There was a problem hiding this comment.
This didn't seem like a patch at first, but makes sense on closer examination. I verified all of the test instructions for the unit and regression tests. always good to 🪓 code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tidies up the
HarmonyAdapter.reformatmethod. The outputs of this service are only GeoTIFF or netCDF4. Although, there is the potential for HGA to be chained with other things that can request a different format. As HGA doesn't know if it is the last step in the chain, we shouldn't raise an exception.Jira Issue ID
TRT-635
Local Test Steps
Check unit tests run:
./bin/build-image && ./bin/build-test && ./bin/run-testCheck regression tests run (updated ones):
.env:LOCALLY_DEPLOYED_SERVICES=harmony-gdal-adapter../bin/bootstrap-harmonyin the Harmony repository)harmony_host_url='http://localhost:3000'. All tests should pass.PR Acceptance Checklist
Jira ticket acceptance criteria met.version.txtandCHANGELOG.mdupdated if any service code is changed.Tests added/updated and passing.Documentation updated (if needed).