Skip to content

TRT-635: Refine HarmonyAdapter.reformat method.#39

Merged
owenlittlejohns merged 1 commit intomainfrom
TRT-635-tidy-up-reformat
Sep 24, 2025
Merged

TRT-635: Refine HarmonyAdapter.reformat method.#39
owenlittlejohns merged 1 commit intomainfrom
TRT-635-tidy-up-reformat

Conversation

@owenlittlejohns
Copy link
Copy Markdown
Member

@owenlittlejohns owenlittlejohns commented Sep 24, 2025

Description

This PR tidies up the HarmonyAdapter.reformat method. The outputs of this service are only GeoTIFF or netCDF4. Although, there is the potential for HGA to be chained with other things that can request a different format. As HGA doesn't know if it is the last step in the chain, we shouldn't raise an exception.

Jira Issue ID

TRT-635

Local Test Steps

Check unit tests run: ./bin/build-image && ./bin/build-test && ./bin/run-test

Check regression tests run (updated ones):

  • Use the branch from this PR against Harmony.
  • Make sure HGA is in your Harmony .env: LOCALLY_DEPLOYED_SERVICES=harmony-gdal-adapter.
  • Start Harmony (./bin/bootstrap-harmony in the Harmony repository)
  • Cut over to the regression test repo.
  • Pull the code from this branch
  • Run the notebook in a browser, changing harmony_host_url='http://localhost:3000'. All tests should pass.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • version.txt and CHANGELOG.md updated if any service code is changed.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

Copy link
Copy Markdown
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't seem like a patch at first, but makes sense on closer examination. I verified all of the test instructions for the unit and regression tests. always good to 🪓 code

@owenlittlejohns owenlittlejohns merged commit 1c359ef into main Sep 24, 2025
4 checks passed
@owenlittlejohns owenlittlejohns deleted the TRT-635-tidy-up-reformat branch September 24, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants