Skip to content

DAS-2382: Remove BaseHarmonyAdapter.set_config call.#45

Merged
owenlittlejohns merged 1 commit intomainfrom
DAS-2832-BaseHarmonyAdapter-set-config
Oct 15, 2025
Merged

DAS-2382: Remove BaseHarmonyAdapter.set_config call.#45
owenlittlejohns merged 1 commit intomainfrom
DAS-2832-BaseHarmonyAdapter-set-config

Conversation

@owenlittlejohns
Copy link
Copy Markdown
Member

Description

This relates to an update to the harmony-service-lib-py. It just pulls out a call the deprecated BaseHarmonyAdapter.set_config method in place of setting it via the __init__ method instead.

Jira Issue ID

DAS-2832

Local Test Steps

  • Pull this branch.
  • Run the unit tests. They should all pass.

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • version.txt and CHANGELOG.md updated if any service code is changed. N/A no changes to service code.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

Copy link
Copy Markdown
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's was fast.

@owenlittlejohns owenlittlejohns merged commit 288035d into main Oct 15, 2025
4 checks passed
@owenlittlejohns owenlittlejohns deleted the DAS-2832-BaseHarmonyAdapter-set-config branch October 15, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants