mitigate urlllib3 vulnerabilies#53
Merged
flamingbear merged 3 commits intomainfrom Dec 17, 2025
Merged
Conversation
Member
|
The change makes sense and I can see the CI/CD passing. I will be able to run the tests locally potentially tomorrow or Wednesday, and then I'll stick a big thumbs up on this PR. |
owenlittlejohns
approved these changes
Dec 17, 2025
Member
owenlittlejohns
left a comment
owenlittlejohns
left a comment
There was a problem hiding this comment.
The changes make sense and I've run the tests locally to confirm that they still pass. Thanks for patching this.
Member
|
I guess - should we cut a release? If this was an operational service, I probably would push for it, because the point of updating the dependencies is to remove the vulnerability from operational code. But this isn't deployed, so maybe it's not so much of an issue? 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps harmony-service-lib to mitigate vulnerabilities.
Opted not to release this version.
Jira Issue ID
None
Local Test Steps
Build and test this branch.
Run HGA regression tests against locahost.
PR Acceptance Checklist
version.txtandCHANGELOG.mdupdated if any service code is changed.