DAS-2415: Add units attribute override to SMAP L3 timestamp variables#32
DAS-2415: Add units attribute override to SMAP L3 timestamp variables#32joeyschultz merged 4 commits intomainfrom
Conversation
| "Attributes": [ | ||
| { | ||
| "Name": "units", | ||
| "Value": "seconds since 2000-01-01 11:58:55.816Z" |
There was a problem hiding this comment.
Just a question and I'm curious. How did you get 2000-01-01 11:58:55.816Z vs
time:units = "seconds since 1970-01-01 00:00:00"
time:units = "seconds since 2000-01-01 00:00:00"
There was a problem hiding this comment.
From the granule metadata (this was taken from SPL3SMP), we can see that the epoch is J2000 and the UTCepoch matches what we are using. seconds since 2000-01-01 00:00:00 would be the J2000 epoch in TT. :
string :epochUTCDateTime = "2000-01-01T11:58:55.816Z" ;
:epochJulianDate = 2451545.f ;
string :timeVariableEpoch = "J2000" ;
Also, the value we chose matches what the SMAP L4 collections use for their timestamp variables.
Matt did a deeper dive exploring this in the WhatsUpWithTime.ipynb notebook attached to the ticket and confirmed this is the correct value for us to use.
|
Test: PASS Test Step:
|
vutrannasa
left a comment
There was a problem hiding this comment.
Looks good. Thanks for answering my questions.
Description
This PR adds a metadata-override to properly annotate the units attribute on SMAP L3 timestamp variables.
Jira Issue ID
DAS-2415
Local Test Steps
Pull this branch, build the service and test images, and ensure the unit tests pass:
./bin/build-image && ./bin/build-test && ./bin/run-testEnsure your HIAB configuration has:
LOCALLY_DEPLOYED_SERVICES=harmony-metadata-annotator,hoss,sds-maskfillRestart harmony to pick up the new metadata-annotator image:
./bin/bootstrap-harmonyRun the DAS-2415.ipynb notebook attached to this ticket. These requests include a variable subset for the timestamp variables in each SMAP L3 collection that should get the units attribute override. Open the downloaded outputs and check that the units attribute was updated.
Run the applicable das-harmony-regression-tests notebooks to ensure no regressions. Make sure to set
harmony_host_url = 'http://localhost:3000/'.PR Acceptance Checklist
CHANGELOG.mdupdated to include high level summary of PR changes.docker/service_version.txtupdated if publishing a release.