Addresses Snyk errors#62
Merged
flamingbear merged 4 commits intomainfrom Dec 17, 2025
Merged
Conversation
Member
Author
lyonthefrog
requested changes
Dec 17, 2025
Contributor
lyonthefrog
left a comment
lyonthefrog
left a comment
There was a problem hiding this comment.
One comment and question! But the tests pass, notebooks run, and I can see that the snyk tests are all passing 👍
| @@ -1,3 +1,9 @@ | |||
| ## unreleased | |||
|
|
|||
| ### Changedale | |||
| @@ -1,3 +1,9 @@ | |||
| ## unreleased | |||
Contributor
There was a problem hiding this comment.
Question on understanding unreleased here - so will we merge this and then I'll absorb it into my version?
Member
Author
There was a problem hiding this comment.
That's what I was thinking. Then you just add that info into your changelog.
lyonthefrog
approved these changes
Dec 17, 2025
Contributor
lyonthefrog
left a comment
lyonthefrog
left a comment
There was a problem hiding this comment.
Cool! We can merge this in and then I'll pull it into my DAS-2446 PR.
D-Auty
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening a PR to try to get Snyk tests passing.
Jira Issue ID
None
Local Test Steps
Should be:
BUT. surprise. The documentation notebooks don't pass and don't pass even before this PR.I updated the notebooks to run.
PR Acceptance Checklist
CHANGELOG.mdupdated to include high level summary of PR changes.docker/service_version.txtupdated if publishing a release.