Skip to content

Conversation

@danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Dec 30, 2025

GitHub Issue: #311

Refactor CI/CD workflows for releasing on publish, improve maintainability

Changes

publish.yml and shell script:

  • Fix checkout to use release tag instead of default branch
  • Configure OIDC trusted publishing for PyPI (removed token-based auth)
  • Add verify_tag.sh

version-and-build.yml:

  • Extract 80-line bash case statement to external script scripts/version_bump.sh for better testability and maintainability (191 → ~110 lines)
  • Fix double-push issue on release branches with ALREADY_COMMITTED flag
  • Only create Git tags on main branch (prevents alpha/RC tag clutter)
  • Clarify publishing logic
  • Add error handling for git operations
  • Remove unused packages: write permission
  • Simplify conditional logic for better readability

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--333.org.readthedocs.build/en/333/

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/1.14.0@00c0eb4). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.14.0     #333   +/-   ##
=================================================
  Coverage                  ?   94.53%           
=================================================
  Files                     ?        9           
  Lines                     ?      531           
  Branches                  ?        0           
=================================================
  Hits                      ?      502           
  Misses                    ?       29           
  Partials                  ?        0           
Flag Coverage Δ
python-3.11 94.53% <ø> (?)
python-3.12 94.53% <ø> (?)
python-3.13 94.53% <ø> (?)
python-3.14 94.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Updated the changelog to reflect changes in Python version and other updates.
@danielfromearth danielfromearth marked this pull request as ready for review December 30, 2025 16:33
@danielfromearth danielfromearth merged commit 6bc82cd into release/1.14.0 Dec 30, 2025
11 checks passed
@danielfromearth danielfromearth deleted the feature/issue-311-pypi-on-release-publishing branch December 30, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants