Skip to content

[nasa/nos3#619] scenario command encryption walkthrough #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

Donnie-Ice
Copy link
Contributor

@Donnie-Ice Donnie-Ice commented Apr 22, 2025

@Donnie-Ice Donnie-Ice requested a review from jlucas9 April 22, 2025 18:35
@Donnie-Ice Donnie-Ice self-assigned this Apr 22, 2025
@Donnie-Ice Donnie-Ice linked an issue Apr 22, 2025 that may be closed by this pull request
@Donnie-Ice
Copy link
Contributor Author

@jlucas9 to fix cmake magic with ground/flight cryptolibs

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (7f59850) to head (ef4f0ae).
Report is 46 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #651      +/-   ##
==========================================
- Coverage   72.86%   72.72%   -0.14%     
==========================================
  Files         747      748       +1     
  Lines       91928    92339     +411     
  Branches     6963     7022      +59     
==========================================
+ Hits        66983    67157     +174     
- Misses      24945    25182     +237     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice Donnie-Ice changed the title WIP: 619 scenario command encryption walkthrough 619 scenario command encryption walkthrough May 1, 2025
@Donnie-Ice
Copy link
Contributor Author

CFDP is currently broken. The file gets from ground to FSW, but then spams errors. Transferring to another Issue.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through and verified it works. Do we want to keep it like this (where cryptolib is fully enabled by default), or in TC mode by default, with the TC/TM stuff commented out for the merge?

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the two minor things I mentioned in the document, everything looks good (and works for me).

@jlucas9 jlucas9 changed the title 619 scenario command encryption walkthrough [nasa/nos3#619] scenario command encryption walkthrough May 6, 2025
@jlucas9
Copy link
Contributor

jlucas9 commented May 14, 2025

Ok it works for me currently using shared folders, but not direct in Linux. Guessing it's a docker user passing issue, will take a deeper look here.

Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through scenario and things worked as specified. Reviewed code; no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario - Command Encryption Walkthrough
6 participants