-
Notifications
You must be signed in to change notification settings - Fork 111
[nasa/nos3#619] scenario command encryption walkthrough #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
@jlucas9 to fix cmake magic with ground/flight cryptolibs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #651 +/- ##
==========================================
- Coverage 72.86% 72.72% -0.14%
==========================================
Files 747 748 +1
Lines 91928 92339 +411
Branches 6963 7022 +59
==========================================
+ Hits 66983 67157 +174
- Misses 24945 25182 +237 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CFDP is currently broken. The file gets from ground to FSW, but then spams errors. Transferring to another Issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through and verified it works. Do we want to keep it like this (where cryptolib is fully enabled by default), or in TC mode by default, with the TC/TM stuff commented out for the merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the two minor things I mentioned in the document, everything looks good (and works for me).
Ok it works for me currently using shared folders, but not direct in Linux. Guessing it's a docker user passing issue, will take a deeper look here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through scenario and things worked as specified. Reviewed code; no comments.
Restored CryptoLib functionality, created scenario docs.
How to test:
Submodule Merges: