ogma-core: Import liftIO from Control.Monad.IO.Class. Refs #215.#218
Merged
ivanperez-keera merged 2 commits intonasa:developfrom Jan 26, 2025
Merged
Conversation
Installing Ogma with GHC 9.6 and it fails because the modules ogma-core:Command.ROSApp and ogma-core:Command.FPrimeApp import liftIO from Control.Monad.Except, which is no longer exported by that module. This is important in general to keep Ogma working with new versions of tools and libraries in the Haskell ecosystem, and to facilitate getting Ogma included in standard distributions. This commit replaces all imports of liftIO from Control.Monad.Except with imports from Control.Monad.IO.Class in both ogma-core:Command.ROSApp and ogma-core:Command.FPrimeApp.
Member
Author
|
Change Manager: Verified that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all imports of
liftIOfromControl.Monad.Exceptwith imports fromControl.Monad.IO.Classin bothogma-core:Command.ROSAppandogma-core:Command.FPrimeApp, as prescribed in the solution proposed for #215.