Skip to content

Restore missing icon-plot-scatter and icon-derived-telemetry icons#8267

Open
charlesh88 wants to merge 1 commit intomasterfrom
restore-missing-glyphs
Open

Restore missing icon-plot-scatter and icon-derived-telemetry icons#8267
charlesh88 wants to merge 1 commit intomasterfrom
restore-missing-glyphs

Conversation

@charlesh88
Copy link
Copy Markdown
Contributor

  • Restored deleted class for .icon-plot-scatter.
  • Rebuilt missing glyph art for icon-derived-telemetry in font JSON file, renewed font files.
  • DO NOT MERGE THIS COMMIT - JUST ACCEPT IT!!!

Testing Notes

  1. Create a Scatter Plot: verify that it displays an icon in the tree.
image
  1. If possible, perform that same check as above in the Create menu in a deployment with Derived Telemetry installed. I was not able to install Derived Telemetry; verified instead by editing the main view icon in Chrome Inspector to change its class to 'icon-derived-telemetry':
image

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in this PR?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

- Restored deleted class for .icon-plot-scatter.
- Rebuilt missing glyph art for icon-derived-telemetry in font JSON file, renewed font files.
- DO NOT MERGE THIS COMMIT - JUST ACCEPT IT!!!
@charlesh88 charlesh88 requested a review from akhenry February 26, 2026 01:05
@charlesh88 charlesh88 added the bug:regression It used to work. Now it doesn't :( label Feb 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.31%. Comparing base (98a5b22) to head (c2cbe4d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8267      +/-   ##
==========================================
+ Coverage   57.30%   57.31%   +0.01%     
==========================================
  Files         725      725              
  Lines       29291    29291              
  Branches     2795     2795              
==========================================
+ Hits        16784    16788       +4     
+ Misses      12167    12163       -4     
  Partials      340      340              
Flag Coverage Δ
e2e-ci 64.50% <ø> (+0.08%) ⬆️
e2e-full 40.27% <ø> (+0.02%) ⬆️
unit 46.85% <ø> (ø)
see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a5b22...c2cbe4d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhenry
Copy link
Copy Markdown
Contributor

akhenry commented Feb 26, 2026

Looks good to me!

DO NOT MERGE THIS COMMIT - JUST ACCEPT IT!!!

ok! I accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug:regression It used to work. Now it doesn't :(

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants