Fix Preview View Switcher to receive good currentView#8311
Open
charlesh88 wants to merge 1 commit intomasterfrom
Open
Fix Preview View Switcher to receive good currentView#8311charlesh88 wants to merge 1 commit intomasterfrom
charlesh88 wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8311 +/- ##
==========================================
- Coverage 57.21% 56.20% -1.01%
==========================================
Files 728 728
Lines 29676 29677 +1
Branches 2804 2805 +1
==========================================
- Hits 16978 16679 -299
- Misses 12358 12658 +300
Partials 340 340
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Updated the currentView computed property to return the view provider object from the viewProviders array instead of the actual view instance. This matches what ViewSwitcher expects - an object with properties like cssClass and name rather than the view instance with methods like show and destroy.
The computed property now:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist