Fix zoom in/out display issues in plots for high precision (especially timestamps) x axis data.#8332
Open
shefalijoshi wants to merge 6 commits into
Open
Fix zoom in/out display issues in plots for high precision (especially timestamps) x axis data.#8332shefalijoshi wants to merge 6 commits into
shefalijoshi wants to merge 6 commits into
Conversation
…’ point. This remains static across frames and only steps forward in clean blocks if the user scrolls an entire page width away, or zooms significantly in or out.
14 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8332 +/- ##
==========================================
+ Coverage 56.14% 57.22% +1.08%
==========================================
Files 728 728
Lines 29728 29755 +27
Branches 2812 2820 +8
==========================================
+ Hits 16690 17027 +337
+ Misses 12698 12387 -311
- Partials 340 341 +1
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jvigliotta
reviewed
Jun 1, 2026
jvigliotta
reviewed
Jun 1, 2026
jvigliotta
reviewed
Jun 1, 2026
jvigliotta
requested changes
Jun 1, 2026
jvigliotta
left a comment
Contributor
There was a problem hiding this comment.
I have one change request about the order we call drawAPI.setDimensions and checkAndApplyReanchor in updateViewport. If it's called after a threshold breach, setDimensions would be using a stale anchorX value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7926
Describe your changes:
WebGL's graphics buffers are limited to single-precision floating-point numbers (Float32Array), which lose numerical accuracy when dealing with large absolute timestamps.
Previously, we used the first point of the telemetry endpoint as the initial data ‘anchor’ point. This caused the offsets to be very large that did not fit into a 32-bit float.
We now use the minimum x value of the current viewport as the ‘anchor’ point. This remains static across frames and only steps forward in clean blocks if the user scrolls an entire page width away, or zooms significantly in or out.
This is agnostic to the type of x-axis data - time series or non-time series.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist